fix(tests): Fix several failing tests #2029
Conversation
Introduced a shared wait_for_url_change utility and updated all relevant Playwright bookmark tests to wait for the URL to change after clicking the bookmark button. This improves test reliability by ensuring the bookmark action completes before proceeding. Also added missing __init__.py files to ensure proper package structure.
Replaces usage of the wait_for_url_change helper with direct calls to page.wait_for_url in all relevant tests. Removes the now-unnecessary bookmark_utils.py and associated __init__.py files, simplifying the test codebase.
Deleted the __init__.py file from tests/playwright as it is no longer needed to mark the directory as a package.
Removed the import and usage of the custom wait_for_url_change utility and replaced it with Playwright's built-in page.wait_for_url method for improved reliability and simplicity.
Eliminated the use and import of stat_smooth in the static_plots example app, simplifying the plot output to only include points and facets.
karangattu
changed the title
Where did you read that |
|
Running the revelant example, I see: 
So it seems the warnings are just notifying that there's not enough points for smoothing in some groups. Is there a way to ignore the warnings? |
The trouble with using Github to come up with PR descriptions because I am lazy... I closed a PR that removed the smooth function #2025 which seemed to fix the tests, but let me look into ignoring the warnings just for that app and for those specific warnings |
Added back stat_smooth with linear model to the ggplot in the static_plots example app. Updated example test to allow a new RuntimeWarning related to insufficient data points for line fitting.
|
@cpsievert I have ignored the warnings now and reverted the stat_smooth use in the plots like before. |
|
Thanks! |
This pull request enhances the reliability of Playwright tests by ensuring URL updates are confirmed after bookmarking actions and includes minor adjustments to test configurations and code comments. The most important changes are grouped below:
Bookmarking Tests Enhancements:
test_accordion_bookmarking.py,test_input_checkbox_express_bookmarking.py,test_navsets_express_bookmarking.py) to verify that the URL updates correctly after clicking the bookmark button.Minor Test Adjustments:
test_navsets_bookmarking_demoto verify the value of a navigation set after bookmarking.Codebase Maintenance:
get_appsfunction inexample_apps.pyto include a new runtime warning in the ignored warnings list.chatlas/app.pyfile to explicitly set turns for theChatOpenAIclient, improving clarity and avoiding potential type issues.