feat: delegate Chat and MarkdownStream implementations to new shinychat dependency
#2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Aug 6, 2025
cpsievert
force-pushed
the
feat/shinychat-dependency
branch
from
bc5bc7d to
8afb668
Compare
cpsievert
force-pushed
the
feat/shinychat-dependency
branch
from
785718f to
157a238
Compare
gadenbuie
reviewed
Aug 8, 2025
cpsievert
force-pushed
the
feat/shinychat-dependency
branch
from
108eba4 to
db88ef5
Compare
|
@gadenbuie ok if I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the implementation for
ChatandMarkdownStreamfromshinyto the newshinychatlibrary (and addsshinychatas a dependency).Note that the initial release of shinychat (v0.1.0) contains the current (as of shiny v1.4.0-dev) implementations verbatim. We also plan on deprecating (posit-dev/shinychat#91) and then removing (posit-dev/shinychat#62) some
Chatfeatures inshinychat. That's because it has become clear in recent months that these features "over-reach" into responsibilities of the AI framework (i.e., chatlas, LangChain, etc), and too tightly coupled UI with LLM state.