Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed false positive warning in `layout_columns()` about number of widths vs elements. (#1704)

* When errors occur in a bookmarking context, they are now reported in the Python console. (#2076)

### Bug fixes

* Fixed numerous issues related to programmatically updating selectize options. (#2053)
Expand Down
13 changes: 4 additions & 9 deletions shiny/bookmark/_bookmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -558,15 +558,10 @@ async def do_bookmark(self) -> None:
await self.show_bookmark_url_modal(full_url)

except Exception as e:
msg = f"Error bookmarking state: {e}"
from ..ui._notification import notification_show

notification_show(
msg,
duration=None,
type="error",
session=self._root_session,
)
from ..types import NotifyException

msg = f"Error bookmarking state: {str(e)}"
raise NotifyException(msg) from e


class BookmarkProxy(Bookmark):
Expand Down
3 changes: 2 additions & 1 deletion shiny/reactive/_reactives.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,9 +597,10 @@ async def _run(self) -> None:
from ..ui import notification_show

msg = str(e)
warnings.warn(msg, ReactiveWarning, stacklevel=2)
if e.sanitize:
msg = SANITIZE_ERROR_MSG
notification_show(msg, type="error", duration=5000)
notification_show(msg, type="error", duration=None)
if e.close:
await self._session._unhandled_error(e)
except Exception as e:
Expand Down
Loading