-
Notifications
You must be signed in to change notification settings - Fork 24
feat(pkg-py): Add new QueryChat() API; hard deprecate old API
#101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QueryChat() API
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started reviewing but have talked myself into thinking we should do a clean break API change rather than try to maintain the older functions in a deprecated state. (See #101 (comment))
QueryChat() APIQueryChat() API; hard deprecate old API
b106177 to
25ed22f
Compare
25ed22f to
732d699
Compare
gadenbuie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, very excited to see this land! Just a couple of tiny things before merging
The PR deprecates essentially the entire current (functional) API in favor of a class-based approach (namely
QueryChat). The new API looks something like this:Express
Core
Closes #97
TODO