feat(pkg-r): bookmark support #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
This PR adds Shiny bookmarking support to the R package's
QueryChatclass, bringing it to feature parity with the Python implementation added in #104.Behavior
When bookmarking is enabled, the following state is preserved across sessions:
shinychat::chat_restore())Note
This does raise some questions related to #113 in terms of managing greeting/chat state. I think it'd be better to leave that for a follow up PR where we can address both R and Python at once.
Changes
mod_server()function - Addedenable_bookmarkingparameter (default:FALSE)shinychat::chat_restore()to save/restore chat historyshiny::onBookmark()handler to save current query, title, and greeting stateshiny::onRestore()handler to restore saved stateQueryChat$server()method - Addedenable_bookmarkingparameter (default:FALSE)mod_server()QueryChat$app_obj()method - Automatically enables bookmarking when appropriatebookmark_store = "url"(default) or"server", bookmarking is automatically enabledbookmark_storeUsage
Using
querychat_app()(automatic)Using
QueryChat$server()in custom apps