Skip to content

feat: sidebar() is now fillable by default #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 2 commits into from
Dec 9, 2025
Merged

feat: sidebar() is now fillable by default #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce81de
feat: sidebar() is now fillable by default
cpsievert Dec 8, 2025
fed5aae
`devtools::document()` (GitHub Actions)
cpsievert Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg-py/src/querychat/_querychat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ def sidebar(
*,
width: int = 400,
height: str = "100%",
fillable: bool = True,
**kwargs,
) -> ui.Sidebar:
"""
Expand All @@ -178,6 +179,8 @@ def sidebar(
Width of the sidebar in pixels.
height
Height of the sidebar.
fillable
Whether the sidebar should be fillable. Default is `True`.
**kwargs
Additional arguments passed to `shiny.ui.sidebar()`.

Expand All @@ -191,6 +194,7 @@ def sidebar(
self.ui(),
width=width,
height=height,
fillable=fillable,
class_="querychat-sidebar",
**kwargs,
)
Expand Down
4 changes: 3 additions & 1 deletion pkg-r/R/QueryChat.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ QueryChat <- R6::R6Class(
#'
#' @param width Width of the sidebar in pixels. Default is 400.
#' @param height Height of the sidebar. Default is "100%".
#' @param fillable Whether the sidebar should be fillable. Default is `TRUE`.
#' @param ... Additional arguments passed to [bslib::sidebar()].
#'
#' @return A [bslib::sidebar()] UI component.
Expand All @@ -396,10 +397,11 @@ QueryChat <- R6::R6Class(
#' # Main content here
#' )
#' }
sidebar = function(width = 400, height = "100%", ...) {
sidebar = function(width = 400, height = "100%", fillable = TRUE, ...) {
bslib::sidebar(
width = width,
height = height,
fillable = fillable,
Copy link
Contributor

@gadenbuie gadenbuie Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we need to release bslib in order to release querychat? Or can we get away with releasing querychat first?

Copy link
Contributor Author

@cpsievert cpsievert Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point -- I don't think we'd have to make it a strict requirement since it's a progressive enhancement, but I also wouldn't be opposed to getting another release out

Copy link
Contributor

@gadenbuie gadenbuie Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool -- I want to get bslib out by end of year but I'd rather push querychat out first if we can.

class = "querychat-sidebar",
...,
self$ui()
Expand Down
4 changes: 3 additions & 1 deletion pkg-r/man/QueryChat.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.