Skip to content

First attempt at genericizing data source (improved!) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chendaniely wants to merge 13 commits into from
Closed

First attempt at genericizing data source (improved!) #19

chendaniely wants to merge 13 commits into from

Conversation

@chendaniely
Copy link
Contributor

@chendaniely chendaniely commented Jun 3, 2025 •
edited
Loading

(Moved TODO items into #21 and #22).

Squash merged into #20 via c6a24a7

Original PR comment:

Updates, changes, fixing conflicts from #5

TODO:

  • create more examples with different database engines (e.g., snowflake, databricks, etc)
  • for snowflake use the user:pass string, but also show example for using snowflake.connector.connect
  • Check readme for new api changes that take dataframe or sqlalchemy connection
  • Check readme for new api changes of returning a querychat object not dict

From the #5 TODO:

  • Use narwhals instead of Pandas directly
  • Have options to limit the number of rows retrieved, or perhaps retrieve in chunks or a cursor, so big databases won't blow up your Shiny app

jcheng5 added 13 commits April 3, 2025 22:47
@jcheng5
First attempt at genericizing data source
973a433
@jcheng5
Unify prompts by adding chevron Python dependency
8de0ac7
@jcheng5
Make prompt aware of what engine is being used
53c7df3
@jcheng5
Replace SQLite support with SQLAlchemy support
a2122f2
@jcheng5
Don't fail when given table name's case differs from SQLAlchemy Inspe…
a218fb9 
…ctor
@jcheng5
Forgot import
dc0814e
@jcheng5
Have server() return proper class with typed methods, instead of dict
9d95d1d
@jcheng5
Auto-create sqlite database for example
aeb87dd
@jcheng5
Have init() take data frame or sqlalchemy engine directly
c38b567 
...instead of requiring explicit DataSource subclass creation
@jcheng5
Merge remote-tracking branch 'origin/main' into generic-datasource-im…
e7972e8 
…provements

Plus some improvements:
- Cleaner .md file reading code in example apps
- Use GPT-4.1 by default, not GPT-4 😬
- Make sqlalchemy required
@jcheng5
Use GPT-4.1 by default, not GPT-4, yuck
57922b3
@jcheng5
Merge remote-tracking branch 'origin/generic-datasource' into generic…
84d30ad 
…-datasource-improvements
@jcheng5
Update README
a08764b
@chendaniely chendaniely changed the base branch from main to dev June 4, 2025 01:02
This was referenced Jun 4, 2025
Open
Open
@chendaniely
Copy link
Contributor Author

chendaniely commented Jun 4, 2025

closing. manually squash merged into #20 via c6a24a7 to preserve Joe as the author of the changes.

@chendaniely chendaniely closed this Jun 4, 2025
@chendaniely chendaniely mentioned this pull request Jun 4, 2025
Closed
5 tasks
@chendaniely chendaniely mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chendaniely @jcheng5