adding collect argument to TblSqlSource execute_query method#199
Open
asb2111 wants to merge 4 commits intoposit-dev:mainfrom
Open
adding collect argument to TblSqlSource execute_query method#199asb2111 wants to merge 4 commits intoposit-dev:mainfrom
asb2111 wants to merge 4 commits intoposit-dev:mainfrom
Conversation
gadenbuie
reviewed
Jan 21, 2026
gadenbuie
reviewed
Jan 21, 2026
| tbl <- dplyr::tbl(conn, table_name) | ||
| tbl <- tbl_transform(tbl) | ||
| tbl <- tbl_transform(tbl) |> | ||
| dplyr::compute("test_table") |
Contributor
There was a problem hiding this comment.
Was this addition required to get the tests to pass? Could you explain why it's needed?
Author
There was a problem hiding this comment.
There was a CTE table name recursion error occurring, this basically 'reset' the name of the table
Contributor
There was a problem hiding this comment.
ah okay, that's a little concerning... was that error happening for you during testing? I can't repro it personally. Can you give some more details (e.g. sessioninfo::session_info() and which test was causing the error)?
Author
There was a problem hiding this comment.
So this was actually occurring prior to any of my changes. Here is my session info:`
─ Session info ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
setting value
version R version 4.5.0 (2025-04-11)
os Red Hat Enterprise Linux 9.5 (Plow)
system x86_64, linux-gnu
ui RStudio
language (EN)
collate en_US.UTF-8
ctype en_US.UTF-8
tz America/New_York
date 2026-01-21
rstudio 2024.12.0+467.pro1 Kousa Dogwood (server)
pandoc 2.14.0.3 @ /usr/bin/pandoc
quarto 1.6.42 @ /data/apps/quarto/1.6.42/bin/quarto
─ Packages ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
package * version date (UTC) lib source
blob 1.2.4 2023-03-17 [1] RSPM (R 4.5.0)
brio 1.1.5 2024-04-24 [1] RSPM (R 4.5.0)
bslib 0.9.0 2025-01-30 [1] RSPM
cachem 1.1.0 2024-05-16 [1] RSPM
callr 3.7.6 2024-03-25 [1] RSPM
cli 3.6.5 2025-04-23 [1] RSPM (R 4.5.0)
commonmark 1.9.5 2025-03-17 [1] RSPM (R 4.5.0)
coro 1.1.0 2024-11-05 [1] CRAN (R 4.5.0)
crayon 1.5.3 2024-06-20 [1] RSPM
DBI 1.2.3 2024-06-02 [1] RSPM (R 4.5.0)
dbplyr 2.5.0 2024-03-19 [1] RSPM
desc 1.4.3 2023-12-10 [1] RSPM (R 4.5.0)
devtools 2.4.5 2022-10-11 [1] RSPM (R 4.5.0)
diffobj 0.3.6 2025-04-21 [1] RSPM (R 4.5.0)
digest 0.6.37 2024-08-19 [1] RSPM
dplyr 1.1.4 2023-11-17 [1] RSPM (R 4.5.0)
duckdb 1.3.1 2025-06-23 [1] RSPM (R 4.5.0)
ellipsis 0.3.2 2021-04-29 [1] RSPM (R 4.5.0)
ellmer 0.4.0 2025-11-15 [1] CRAN (R 4.5.0)
evaluate 1.0.4 2025-06-18 [1] RSPM (R 4.5.0)
fastmap 1.2.0 2024-05-15 [1] RSPM
fs 1.6.6 2025-04-12 [1] RSPM
generics 0.1.4 2025-05-09 [1] RSPM (R 4.5.0)
glue 1.8.0 2024-09-30 [1] RSPM (R 4.5.0)
htmltools 0.5.8.1 2024-04-04 [1] RSPM
htmlwidgets 1.6.4 2023-12-06 [1] RSPM (R 4.5.0)
httpuv 1.6.16 2025-04-16 [1] RSPM (R 4.5.0)
httr2 1.2.2 2025-12-08 [1] CRAN (R 4.5.0)
jquerylib 0.1.4 2021-04-26 [1] RSPM
jsonlite 2.0.0 2025-03-27 [1] RSPM
knitr 1.50 2025-03-16 [1] RSPM
later 1.4.2 2025-04-08 [1] RSPM (R 4.5.0)
lifecycle 1.0.4 2023-11-07 [1] RSPM (R 4.5.0)
magrittr 2.0.3 2022-03-30 [1] RSPM (R 4.5.0)
memoise 2.0.1 2021-11-26 [1] RSPM
mime 0.13 2025-03-17 [1] RSPM
miniUI 0.1.2 2025-04-17 [1] RSPM (R 4.5.0)
pillar 1.10.2 2025-04-05 [1] RSPM (R 4.5.0)
pkgbuild 1.4.8 2025-05-26 [1] RSPM (R 4.5.0)
pkgconfig 2.0.3 2019-09-22 [1] RSPM (R 4.5.0)
pkgload 1.4.0 2024-06-28 [1] RSPM (R 4.5.0)
processx 3.8.6 2025-02-21 [1] RSPM
profvis 0.4.0 2024-09-20 [1] RSPM (R 4.5.0)
promises 1.3.3 2025-05-29 [1] RSPM (R 4.5.0)
ps 1.9.1 2025-04-12 [1] RSPM
purrr 1.0.4 2025-02-05 [1] RSPM (R 4.5.0)
R6 2.6.1 2025-02-15 [1] RSPM (R 4.5.0)
rappdirs 0.3.3 2021-01-31 [1] RSPM
Rcpp 1.0.14 2025-01-12 [1] RSPM
remotes 2.5.0 2024-03-17 [1] RSPM (R 4.5.0)
rlang 1.1.6 2025-04-11 [1] RSPM (R 4.5.0)
roxygen2 7.3.3 2025-09-03 [1] CRAN (R 4.5.0)
rprojroot 2.0.4 2023-11-05 [1] RSPM (R 4.5.0)
rstudioapi 0.17.1 2024-10-22 [1] RSPM
S7 0.2.0 2024-11-07 [1] RSPM (R 4.5.0)
sass 0.4.10 2025-04-11 [1] RSPM
sessioninfo 1.2.3 2025-02-05 [1] RSPM (R 4.5.0)
shiny 1.11.0 2025-06-24 [1] RSPM (R 4.5.0)
stringi 1.8.7 2025-03-27 [1] RSPM (R 4.5.0)
stringr 1.5.1 2023-11-14 [1] RSPM (R 4.5.0)
testthat 3.2.3 2025-01-13 [1] RSPM (R 4.5.0)
tibble 3.3.0 2025-06-08 [1] RSPM (R 4.5.0)
tidyselect 1.2.1 2024-03-11 [1] RSPM (R 4.5.0)
urlchecker 1.0.1 2021-11-30 [1] RSPM (R 4.5.0)
usethis 3.1.0 2024-11-26 [1] RSPM (R 4.5.0)
utf8 1.2.6 2025-06-08 [1] RSPM (R 4.5.0)
vctrs 0.6.5 2023-12-01 [1] RSPM (R 4.5.0)
waldo 0.6.1 2024-11-07 [1] RSPM (R 4.5.0)
whisker 0.4.1 2022-12-05 [1] RSPM (R 4.5.0)
withr 3.0.2 2024-10-28 [1] RSPM (R 4.5.0)
xfun 0.52 2025-04-02 [1] RSPM
xml2 1.3.8 2025-03-14 [1] RSPM
xtable 1.8-4 2019-04-21 [1] RSPM (R 4.5.0)
[1] /home/alexander.breskin/R/4.5.0
[2] /opt/R/4.5.0/lib/R/library
Here is the specific test failure:
Error (test-TblSqlSource.R:62:5): TblSqlSource with transformed tbl (CTE mode): works with filtered tbl
Error in `db_query_fields.DBIConnection(con, ...)`: Can't query fields.
i Using SQL: SELECT * FROM ( WITH test_table AS ( SELECT test_table.* FROM test_table WHERE ("value" > 20.0) ) SELECT * FROM test_table ) q01 WHERE (0 = 1)
Caused by error in `dbSendQuery()`:
! rapi_prepare: Failed to prepare query SELECT *
FROM (
WITH test_table AS (
SELECT test_table.*
FROM test_table
WHERE ("value" > 20.0)
)
SELECT * FROM test_table
) q01
WHERE (0 = 1)
Error: Binder Error: Circular reference to CTE "test_table", There are two possible solutions.
1. use WITH RECURSIVE to use recursive CTEs.
2. If you want to use the TABLE name "test_table" the same as the CTE name, please explicitly add "SCHEMA" before table name. You can try "main.test_table" (main is the duckdb default schema)
I tried the second suggestion, using 'main.test_table' in the query, but that didn't work because it overrode the >20 filter.
Contributor
There was a problem hiding this comment.
Oh interesting... querychat has a pattern of wanting the user to provide a table_name, e.g. querychat(mtcars, "my_mtcars"), but for tibbles we try to figure out the name of the underlying table. This failure seems to indicate that something in going wrong and querychat thinks the table names are different, even though they clearly aren't. Or maybe for this particular test we can't figure out the underlying table name and the test needs to use a different table name that isn't test_table.
gadenbuie
reviewed
Jan 21, 2026
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a collect argument to execute_query for TblSqlSource, #198