Optimizing Schema Queries #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
Jun 6, 2025
Collaborator
|
I didn't really look closely at this but generic-datasource-improvements ought to get a comprehensive review later anyway. |
jcheng5
merged commit 43ee050
into
posit-dev:generic-datasource-improvements
16 checks passed
chendaniely
added a commit
that referenced
this pull request
Jun 12, 2025
chendaniely
added a commit
that referenced
this pull request
Jun 12, 2025
chore: add pytest in pyproject toml, but uses current tool.uv table tests: oops put test code in wrong file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current serial execution of the queries in
SQLAlchemyDataSource.get_schema()can be a bit slow, especially on a wide table. This refactors that method to instead run just two queries, which provides a significant speedup. Also added a testing framework for the SQLAlchemyDataSource