fix(update_dashboard): Return a confirmation message on successful update#57
Merged
fix(update_dashboard): Return a confirmation message on successful update#57
Conversation
gadenbuie
commented
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
Prior to this PR,
update_dashboard()tool doesn't return a value -- or in the R case it returns eitherTRUEorFALSEdepending on whether thetitleis updated.This appears to confuse models, especially local models. This PR updates the tool return value to tell the model the dashboard was updated and to instruct it to use the query tool if needed to see the results.