feat: simplify styles, give querychat components classes#68
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes styles between Python and R packages and improves component identification by adding CSS classes to querychat components.
- Unified
styles.cssfiles between Python and R packages for consistent styling - Added
.querychatand.querychat-sidebarCSS classes to components for better customization - Updated Python examples to use the new
clientargument instead of deprecatedcreate_chat_callback
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg-r/man/querychat_ui.Rd | Updated documentation formatting and cross-references |
| pkg-r/man/querychat_init.Rd | Improved documentation formatting and line wrapping |
| pkg-r/inst/htmldep/styles.css | Simplified CSS to match Python package and added sidebar collapse positioning |
| pkg-r/R/querychat_app.R | Added bslib-page-dashboard class and cleaned up function call |
| pkg-r/R/querychat.R | Added CSS classes to components and improved documentation |
| pkg-r/NEWS.md | Added changelog entry for new CSS classes |
| pkg-py/src/querychat/static/css/styles.css | Unified with R package styles |
| pkg-py/src/querychat/querychat.py | Added querychat CSS classes to UI components |
| pkg-py/examples/*.py | Updated to use client instead of create_chat_callback |
| pkg-py/CHANGELOG.md | Added changelog entry for new CSS classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few style-level changes to align Python and R packages and improve styles:
styles.cssfile in both packages.querychatto thechat_ui()component used by querychat.querychat-sidebarto thesidebar()created byquerychat_sidebar()clientargument in Python examplesquerychat_sidebar()to stay out of the way of tool cards in the sidebar.