Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements rich tool UI support for the Python querychat package, replacing basic text-based tool outputs with interactive buttons and enhanced visual feedback. The main changes include switching from Shiny's basic chat UI to shinychat's rich tool display system, and adding a new tool for resetting dashboard filters.
- Adds rich tool UI with interactive buttons using shinychat and updated chatlas dependency
- Introduces a reset dashboard tool for easy filter clearing
- Refactors tool functions into a separate module with enhanced visual feedback
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates dependencies to include shinychat and chatlas version requirements |
| pkg-py/src/querychat/tools.py | New module containing tool functions with rich UI support |
| pkg-py/src/querychat/static/js/querychat.js | JavaScript for handling tool button interactions |
| pkg-py/src/querychat/querychat.py | Updates to use shinychat and new tool system |
| pkg-py/src/querychat/prompt/prompt.md | Updates tool names in system prompt |
| pkg-py/src/querychat/_utils.py | Moves df_to_html utility function here |
| pkg-py/examples/app.py | Updates example to use dynamic title display |
| pkg-py/CHANGELOG.md | Documents the new features |
Comments suppressed due to low confidence (1)
pyproject.toml:1
- This line was removed from the ruff ignore list but there's no indication why this rule should now be enforced. The removal could cause linting failures if
dfis used as a variable name elsewhere in the codebase.
[build-system]
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Closes #81