Skip to content

Comments

feat: Add querychat_greeting()#87

Merged
gadenbuie merged 10 commits intomainfrom
feat/querychat-greeting
Sep 12, 2025
Merged

feat: Add querychat_greeting()#87
gadenbuie merged 10 commits intomainfrom
feat/querychat-greeting

Conversation

@gadenbuie
Copy link
Contributor

A function to help generate a greeting from a querychat config object

@gadenbuie gadenbuie requested a review from Copilot September 12, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new querychat_greeting() function to help users generate greeting messages for their querychat bots. The function allows users to either retrieve existing greetings or generate new ones using the configured LLM, providing better flexibility and user experience.

  • Added querychat_greeting() function in both R and Python packages
  • Updated documentation and examples to reference the new greeting function
  • Simplified greeting logic in the server module to use the new function

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Added palmerpenguins dependency for examples
pkg-r/tests/testthat/test-querychat-greeting.R Comprehensive test suite for R querychat_greeting function
pkg-r/man/querychat_server.Rd Fixed spelling error "Initalize" → "Initialize"
pkg-r/man/querychat_init.Rd Updated documentation to reference new greeting function
pkg-r/man/querychat_greeting.Rd Documentation for new querychat_greeting function
pkg-r/R/querychat_greeting.R Implementation of querychat_greeting function for R
pkg-r/R/querychat.R Updated to use new greeting function and fixed spelling
pkg-r/NEWS.md Added changelog entry for new feature
pkg-r/NAMESPACE Exported new querychat_greeting function
pkg-py/tests/test_greeting.py Test suite for Python greeting function
pkg-py/src/querychat/querychat.py Updated documentation to reference new greeting function
pkg-py/src/querychat/_greeting.py Implementation of greeting function for Python
pkg-py/src/querychat/init.py Exported new greeting function
pkg-py/docs/index.qmd Updated documentation with greeting function examples
pkg-py/CHANGELOG.md Added changelog entry for new feature
.vscode/settings.json Added pytest configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gadenbuie gadenbuie merged commit 35f6932 into main Sep 12, 2025
16 checks passed
@gadenbuie gadenbuie deleted the feat/querychat-greeting branch September 12, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant