Conversation
* Gives an easy way to generate a greeting once
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new querychat_greeting() function to help users generate greeting messages for their querychat bots. The function allows users to either retrieve existing greetings or generate new ones using the configured LLM, providing better flexibility and user experience.
- Added
querychat_greeting()function in both R and Python packages - Updated documentation and examples to reference the new greeting function
- Simplified greeting logic in the server module to use the new function
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added palmerpenguins dependency for examples |
| pkg-r/tests/testthat/test-querychat-greeting.R | Comprehensive test suite for R querychat_greeting function |
| pkg-r/man/querychat_server.Rd | Fixed spelling error "Initalize" → "Initialize" |
| pkg-r/man/querychat_init.Rd | Updated documentation to reference new greeting function |
| pkg-r/man/querychat_greeting.Rd | Documentation for new querychat_greeting function |
| pkg-r/R/querychat_greeting.R | Implementation of querychat_greeting function for R |
| pkg-r/R/querychat.R | Updated to use new greeting function and fixed spelling |
| pkg-r/NEWS.md | Added changelog entry for new feature |
| pkg-r/NAMESPACE | Exported new querychat_greeting function |
| pkg-py/tests/test_greeting.py | Test suite for Python greeting function |
| pkg-py/src/querychat/querychat.py | Updated documentation to reference new greeting function |
| pkg-py/src/querychat/_greeting.py | Implementation of greeting function for Python |
| pkg-py/src/querychat/init.py | Exported new greeting function |
| pkg-py/docs/index.qmd | Updated documentation with greeting function examples |
| pkg-py/CHANGELOG.md | Added changelog entry for new feature |
| .vscode/settings.json | Added pytest configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function to help generate a greeting from a querychat config object