Skip to content

Add logs url on failure #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Add logs url on failure #642

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2468992
Add logs url on failure
jonkeane Mar 7, 2025
bf9ade8
tab space, not tab
jonkeane Mar 7, 2025
635a71e
avoid the possible KeyError
jonkeane Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rsconnect/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ def app_access(self, app_guid: str) -> None:
if self.is_app_failed_response(response):
raise RSConnectException(
"Could not access the deployed content. "
+ "The app might not have started successfully. "
+ "Visit it in Connect to view the logs."
+ "The app might not have started successfully."
+ f"\n\t For more information: {self.app_config(app_guid)['logs_url']}"
Copy link
Collaborator

@tdstein tdstein Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paranoid programmer in me says to avoid the possible KeyError before the exception is raised.

Suggested change
+ f"\n\t For more information: {self.app_config(app_guid)['logs_url']}"
+ f"\n\tFor more information: {self.app_config(app_guid).get('logs_url')}"

Copy link
Collaborator Author

@jonkeane jonkeane Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) yes, agreed about the key error (2) the there is (sadly) intentional to avoid needing to s/\t /\t/g elsewhere

)

def bundle_download(self, content_guid: str, bundle_id: str) -> HTTPResponse:
Expand Down
Loading