Skip to content

fix: change send button selector to a specific class instead of generic <button> #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change send button selector to a specific class instead of generic <button> #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/chat/chat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ shiny-chat-input {
color: var(--bs-gray-600, #707782) !important;
}
}
button {
button.chat-send-button {
position: absolute;
bottom: calc(6px + var(--_input-padding-bottom));
right: 8px;
Expand Down
3 changes: 2 additions & 1 deletion js/src/chat/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class ChatInput extends LightElement {
}

private get button(): HTMLButtonElement {
return this.querySelector("button") as HTMLButtonElement
return this.querySelector("button.chat-send-button") as HTMLButtonElement
}

render() {
Expand All @@ -243,6 +243,7 @@ class ChatInput extends LightElement {
></textarea>
<button
type="button"
class="chat-send-button"
title="Send message"
aria-label="Send message"
@click=${this.#sendInput}
Expand Down
2 changes: 1 addition & 1 deletion pkg-py/src/shinychat/playwright/_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def __init__(self, page: Page, id: str) -> None:
self.loc_latest_message = self.loc_messages.locator("> :last-child")
self.loc_input_container = self.loc.locator("> shiny-chat-input")
self.loc_input = self.loc_input_container.locator("textarea")
self.loc_input_button = self.loc_input_container.locator("button")
self.loc_input_button = self.loc_input_container.locator("button.chat-send-button")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an equivalent test for R but I figured it makes sense to repair the Python test.


def expect_latest_message(
self,
Expand Down