Skip to content

Conversation

@dumbasPL
Copy link

yaml values containing : need to be wrapped in quotes

The old example config would crash the app

yaml values containing `:` need to be wrapped in quotes

Signed-off-by: nezu <[email protected]>
@willpower232
Copy link
Collaborator

Great spot, thanks!

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 18, 2024
@dumbasPL
Copy link
Author

hi?

@willpower232
Copy link
Collaborator

it is supposed to ignore things that have been labelled but apparently it doesn't work 👌

@dumbasPL
Copy link
Author

Is there a reason this isn't merged already? Am I missing something?

@willpower232
Copy link
Collaborator

The only thing missing is some available time from the actual mantainers who can make commits 😅

@catphish
Copy link
Contributor

This looks good to me, sorry for the delay in merging. I will try to test myself before actually merging but looks like an obvious fix.

@dtrckd
Copy link

dtrckd commented Nov 26, 2024

I confirm the fix works. Is there anything that prevent the merging ?

By the way, it seems there is another error in the config doc file.
It set a return_path:, but the correct value seems to actually be return_path_domain:.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Feb 11, 2025
@dtrckd
Copy link

dtrckd commented Feb 11, 2025

Not stale.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 2, 2025
@dumbasPL
Copy link
Author

dumbasPL commented Oct 2, 2025

bruh

dead project?

@willpower232 willpower232 removed the stale label Oct 2, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants