fix: add X-Envelope-From header #3512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
X-Envelope-Fromheader to incoming messages to preserve the SMTPenvelope sender (
MAIL FROM) for SPF evaluation by SpamAssassin.Background
SpamAssassin relies on message headers to determine the envelope sender for SPF checks.
If no suitable header is present (e.g.
Return-PathorX-Envelope-From), SPF evaluationmay be skipped and debug messages such as
cannot get Envelope-Fromare logged.Motivation
Providing
X-Envelope-Fromensures the envelope sender is always available for SPFevaluation, improving accuracy and consistency with SpamAssassin’s documented behavior.
References
Impact