Skip to content

Check in Javascript if variables are set when initializing the module (#77) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paulsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check in Javascript if variables are set when initializing the module (#77) #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion view/frontend/web/js/form/components/address-autofill-nl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@ define([
},

resetHouseNumberSelect: function () {
this.childHouseNumberSelect().setOptions([]).hide();
const childHouseNumberSelect = this.childHouseNumberSelect();
if(childHouseNumberSelect){
childHouseNumberSelect.setOptions([]).hide();
}
},

getAddressParts: function (address) {
Expand Down
8 changes: 5 additions & 3 deletions view/frontend/web/js/form/element/address-autofill-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ define([
initialize: function () {
this._super();

if (this.settings.show_hide_address_fields !== 'show') {
this.validation['required-entry'] = true;
this.required(true);
if(this.settings) {
if (this.settings.show_hide_address_fields !== 'show') {
this.validation['required-entry'] = true;
this.required(true);
}
}

return this;
Expand Down
14 changes: 8 additions & 6 deletions view/frontend/web/js/form/element/address-autofill-intl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ define([
initialize: function (config) {
this._super();

if (this.settings.show_hide_address_fields !== 'show') {
this.validation['validate-callback'] = {
message: $t('Please enter an address and select it.'),
isValid: this.isValid.bind(this),
};
this.required(true);
if (this.settings){
if (this.settings.show_hide_address_fields !== 'show') {
this.validation['validate-callback'] = {
message: $t('Please enter an address and select it.'),
isValid: this.isValid.bind(this),
};
this.required(true);
}
}

this.additionalClasses['loading'] = this.loading;
Expand Down
14 changes: 8 additions & 6 deletions view/frontend/web/js/form/element/house-number-select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ define([
initialize: function () {
this._super();

if (this.settings.show_hide_address_fields !== 'show') {
this.validation['validate-callback'] = {
message: $t('Please select a house number.'),
isValid: this.isValid.bind(this),
};
this.required(true);
if (this.settings){
if (this.settings.show_hide_address_fields !== 'show') {
this.validation['validate-callback'] = {
message: $t('Please select a house number.'),
isValid: this.isValid.bind(this),
};
this.required(true);
}
}

return this;
Expand Down