Topic/migrate to sonatype central #144
Conversation
- Update URLs to https Signed-off-by: Phillip Ross <[email protected]>
📝 WalkthroughWalkthroughThe changes update Maven and GitHub Actions configurations to switch repository deployment from the old Sonatype OSSRH setup to the new Sonatype Central Portal. This includes renaming profiles, updating server and repository IDs, modifying environment variables, and replacing URLs and plugins in the POM and workflow files. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Maven
participant Sonatype Central Portal
Developer->>GitHub Actions: Push code / trigger workflow
GitHub Actions->>Maven: Run build & deploy with new profiles and credentials
Maven->>Sonatype Central Portal: Deploy artifacts using central-publishing-maven-plugin
Sonatype Central Portal-->>Maven: Acknowledge deployment
Maven-->>GitHub Actions: Report deployment status
GitHub Actions-->>Developer: Notify build/deployment result
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/main.yml (1)
28-28: Ensure PROFILES env matches configuration: ThePROFILESvariable lists the Maven profiles to activate. Double-check that these profile IDs (gpg,release-sign-artifacts,sonatype-central-portal-deployment,sonatype-central-snapshots) exactly match those declared insettings.xmlandpom.xml. Also consider quoting the comma-separated string to prevent YAML parsing issues:env: - PROFILES: gpg,release-sign-artifacts,sonatype-central-portal-deployment,sonatype-central-snapshots + PROFILES: "gpg,release-sign-artifacts,sonatype-central-portal-deployment,sonatype-central-snapshots"pom.xml (1)
862-865: Fix malformed XML comment: The comment block for therelease-sign-artifactsprofile is missing a closing parenthesis and has inconsistent phrasing. Consider revising for clarity:- <!-- - The release-sign-artifacts and sonatype-central-portal-deployment profiles only need activated when pushing - snapshots or releases to maven central. When enabled, additional artifacts will be generated for javadoc and - source as well as GPG signatures for each artifact. These profiles assume that the properties for the gpg - plugin (such as gpg.keyname and gpg.passphrase are either defined in a settings.xml file or similar facility. - --> + <!-- + The release-sign-artifacts and sonatype-central-portal-deployment profiles need activation only when publishing + snapshots or releases to Maven Central. When enabled, additional artifacts will be generated (javadoc, source) + and each artifact will be GPG-signed. Ensure properties for the GPG plugin (e.g., gpg.keyname and gpg.passphrase) + are defined in a settings.xml or equivalent. + -->
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/settings.xml(2 hunks).github/workflows/main.yml(2 hunks)pom.xml(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Build on OS ubuntu-24.04 using JDK 24.0.1-zulu
- GitHub Check: Build on OS ubuntu-24.04 using JDK 8.0.452-zulu
- GitHub Check: Build on OS ubuntu-24.04 using JDK 11.0.27-zulu
- GitHub Check: Build on OS ubuntu-24.04 using JDK 17.0.15-zulu
- GitHub Check: Build on OS ubuntu-24.04 using JDK 21.0.7-zulu
🔇 Additional comments (12)
.github/workflows/main.yml (1)
85-86: Verify repository credentials secrets: The workflow now usesSONATYPE_CENTRAL_PORTAL_REPO_USERNAMEandSONATYPE_CENTRAL_PORTAL_REPO_PASSWORD. Ensure these secrets are created in the repository settings and have correct values, or the deploy step will fail..github/settings.xml (1)
6-9: Confirm server ID consistency: The<id>has been updated tosonatype-central-portal, matching the new plugin’spublishingServerId. This aligns settings withpom.xmland the workflow.pom.xml (10)
12-12: Switch project URL to HTTPS: The project<url>has been updated to use HTTPS. Using HTTPS for project metadata is a best practice for security and trust.
16-16: Update license URL to HTTPS: The license URL now uses HTTPS. This ensures secure retrieval of license text.
24-24: Update developer URL to HTTPS: Changing tohttps://postgis.netis consistent and secure.
38-38: Update contributor URL to HTTPS: Switching tohttps://www.gurkensalat.com/aligns the link with secure protocol.
58-58: Update user list archive URL: Changing to the OSGeo Pipermail archive over HTTPS is appropriate.
65-65: Update developer list archive URL: The HTTPS archive URL is correct.
90-90: Review distributionManagement site URL: The staging site URL is set tohttps://local-staging/. Verify whether this placeholder should be updated or parameterized for different environments.
464-464: Align<releaseProfiles>with workflow: The<releaseProfiles>now includesonatype-central-portal-deployment. Ensure this matches the profiles activated in the CI workflow.
912-915: Definesonatype-central-portal-deploymentprofile properties: The profile is correctly configured with thecentral-publishing-maven-plugin.versionproperty. This ensures the plugin version can be managed.
916-937: Configure central-publishing-maven-plugin: Thesonatype-central-portal-deploymentprofile now includes the plugin configuration to publish via the new Sonatype Central Portal. This matches the migration plan.
phillipross
force-pushed
the
topic/migrate-to-sonatype-central
branch
from
0cc8e1f to
ce384a1
Compare
phillipross
force-pushed
the
topic/migrate-to-sonatype-central
branch
from
ce384a1 to
d3983e3
Compare
1 participant
No description provided.