Skip to content

Fix build warnings #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+83 −63
Open

Fix build warnings #652

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58d01f2
Fix warning about shadows a previous local variable
japinli Jun 4, 2025
974956c
Fix warning about mixed declarations and code
japinli Jun 4, 2025
ba84855
Fix warning about discarding const qualifier
japinli Jun 4, 2025
501ffd9
Fix warning about no previous declaration
japinli Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ fio_gzread(gzFile f, void *buf, unsigned size)
{
gz->strm.next_in = gz->buf;
}
rc = fio_read(gz->fd, gz->strm.next_in + gz->strm.avail_in,
rc = fio_read(gz->fd, (void *) (gz->strm.next_in + gz->strm.avail_in),
Copy link

@Ogurezzz Ogurezzz Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to discard const qualifier because external library, probably, can cache some values because expected constant value.

gz->buf + ZLIB_BUFFER_SIZE - gz->strm.next_in - gz->strm.avail_in);
if (rc > 0)
{
Expand Down