Removing lock files #781
Merged
Removing lock files #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aman-v-singh
commented
Dec 17, 2024
aman-v-singh
commented
- Removed package lock and added files to not commit to .gitignore.
- This can help with fixing Regression in v1.11.0: detected package manager defaults to yarn #780
VShingala
approved these changes
Dec 18, 2024
Member
|
@aman-v-singh There are other concerns also mentioned in original issue that I'm not sure if we've addressed with this issue. It also makes sense to me. We can discuss more in original issue if there are any counter points to doing the change suggested there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.