chore: added iterations opimization #1525

vinayakparashar · 2025-09-10T15:26:27Z

Added performance optimization for iteration execution

lib/runner/run.js

codenirvana · 2025-09-10T18:16:28Z

lib/runner/run.js

            });
        }
+        // if custom parallel iterations is true, then set the areIterationsParallelized to true
+        this.areIterationsParallelized = this.options?.customParallelIterations ||


Why is this state not saved in the Partition Manager instance?

Because this state is only used by the run instance. based on it's value run instance will decide whether to use the partition manager or no.

codenirvana · 2025-09-10T19:47:03Z

lib/runner/extensions/waterfall.command.js

        this.snrHash = null; // we populate it in the first SNR call

-        done();
+        return done();


why return callback?

codenirvana · 2025-09-10T19:51:53Z

lib/runner/extensions/parallel.command.js

I see we've moved some code to utils, but there's still a lot of duplicate code from the waterfall command. Why can't it queue the waterfall or find a better way to avoid this duplication?

I have created a separate function to handle the SNR logic, which reduces duplicate code.

While we could make changes to the ⁠waterfall command, we prefer to avoid modifying it or introducing additional conditional statements. Doing so could negatively affect its performance and make the overall logic harder to understand. For this reason, we have chosen to implement a completely new command for parallel runs, even if it means some code duplication.

codenirvana · 2025-09-10T20:34:05Z

lib/runner/run.js

+    /**
+ * Starts a parallel iteration
+ * @param {Number} index - The index of the partition to run
+ * @param {Object} localVariables - Local variables for the iteration
+ * @param {Function} callback - The callback to call when the iteration is complete
+ */
+    startParallelIteration (index, localVariables, callback) {
+        this.partitionManager.runSinglePartition(index, localVariables, callback);
+    },
+
+    /**
+     * Stops a parallel iteration
+     * @param {Number} index - The index of the partition to stop
+     * @param {Function} callback - The callback to call when the iteration is complete
+     */
+    stopParallelIteration (index, callback) {
+        this.partitionManager.stopSinglePartition(index, callback);
+    },
+
+


I don't see these methods being used. Do we still need them?

yes, these are methods exposed for external orchestration not used inside the code directly.

In that case, move these to the prototype object of parallel.command.

codenirvana · 2025-09-10T20:39:23Z

lib/runner/extensions/event.command.js

                            result && result._variables &&
                                (this.state._variables = new sdk.VariableScope(result._variables));

+                            // persist the pm.variables for the next request in the current iteration


What's happening here?

Since each partition needs to track it's own variables, we are updating the variables for that partition only. So we do not affect other partitions.

This can be a helper function in partition manager, something like: this.partitionManager.persistVariables(result._variables).

Co-authored-by: Udit Vasu <udit@pm.me>

codecov · 2025-09-11T15:23:38Z

Codecov Report

❌ Patch coverage is 91.52542% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.20%. Comparing base (c2a4a7a) to head (21b3b0c).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
lib/runner/partition-manager.js	90.83%	5 Missing and 7 partials ⚠️
lib/runner/extensions/parallel.command.js	88.46%	5 Missing and 1 partial ⚠️
lib/runner/run.js	72.72%	2 Missing and 1 partial ⚠️
lib/runner/partition.js	93.10%	1 Missing and 1 partial ⚠️
lib/runner/util.js	96.07%	0 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (91.52%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1525       +/-   ##
============================================
+ Coverage    38.59%   75.20%   +36.61%     
============================================
  Files           46       49        +3     
  Lines         3537     3779      +242     
  Branches      1027     1081       +54     
============================================
+ Hits          1365     2842     +1477     
+ Misses        2074      713     -1361     
- Partials        98      224      +126

Flag	Coverage Δ
integration	`65.41% <78.30%> (?)`
legacy	`36.80% <24.74%> (?)`
unit	`41.99% <64.06%> (+3.40%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codenirvana · 2025-09-11T21:53:34Z

lib/runner/extensions/control.command.js

-            // the process tick
-            backpack.ensure(userback, this) && userback();
-
+            this.partitionManager && this.partitionManager.clearPools();


In what situations can this.partitionManager be undefined?

In Production code, never. but since partitionManager isn't a part of the main execution loop (which is waterfall), this is just a defensive measure for future proofing and run object manipulation.
let me know if this check should be removed.

codenirvana · 2025-09-11T21:54:08Z

lib/runner/extensions/control.command.js

-            // the process tick
-            backpack.ensure(userback, this) && userback();
-
+            this.partitionManager && this.partitionManager.clearPools();


Maybe just .clear() or .dispose().

codenirvana · 2025-09-11T22:04:11Z

lib/runner/extensions/control.command.js

+                // do so in a try block to ensure it does not hamper the process tick
+                backpack.ensure(userback, this) && userback();
+            }
+            this.partitionManager && this.partitionManager.triggerStopAction();


I believe we should include this in this.partitionManager.dispose(), which clears and triggers the stop.

codenirvana · 2025-09-11T22:06:36Z

lib/runner/extensions/event.command.js

                            result && result._variables &&
                                (this.state._variables = new sdk.VariableScope(result._variables));

+                            // persist the pm.variables for the next request in the current iteration


This can be a helper function in partition manager, something like: this.partitionManager.persistVariables(result._variables).

codenirvana · 2025-09-15T22:50:14Z

lib/runner/run.js

+    /**
+ * Starts a parallel iteration
+ * @param {Number} index - The index of the partition to run
+ * @param {Object} localVariables - Local variables for the iteration
+ * @param {Function} callback - The callback to call when the iteration is complete
+ */
+    startParallelIteration (index, localVariables, callback) {
+        this.partitionManager.runSinglePartition(index, localVariables, callback);
+    },
+
+    /**
+     * Stops a parallel iteration
+     * @param {Number} index - The index of the partition to stop
+     * @param {Function} callback - The callback to call when the iteration is complete
+     */
+    stopParallelIteration (index, callback) {
+        this.partitionManager.stopSinglePartition(index, callback);
+    },
+
+


In that case, move these to the prototype object of parallel.command.

added iterations opimization

efa4a1a

vinayakparashar requested review from codenirvana and shamasis September 10, 2025 15:26

codenirvana requested changes Sep 10, 2025

View reviewed changes

KhudaDad414 and others added 4 commits September 11, 2025 15:47

add processExecutionResult function to minimize code duplication

3484af2

remove return statement from done() call

8c9b292

Update lib/runner/run.js

563f440

Co-authored-by: Udit Vasu <udit@pm.me>

add tests

77f41e0

KhudaDad414 and others added 5 commits September 11, 2025 17:59

add some tests and safeguards

0d7690e

remove faulty tests

f75f88e

abort issue fixes

231ec63

remove faulty test

1394388

abort sceanrio additonal test

5e7c989

codenirvana requested changes Sep 15, 2025

View reviewed changes

KhudaDad414 and others added 6 commits September 16, 2025 09:48

address comments

694d9c5

pr comments addressed

9d5ac2d

Fix formatting

96bf265

Fix test

133d0cf

Merge branch 'develop' into chore/iteration-optimizations

2263b3b

fix dispose method

21b3b0c

appurva21 merged commit 455b308 into develop Sep 18, 2025
17 of 21 checks passed

appurva21 deleted the chore/iteration-optimizations branch September 18, 2025 06:33

chore: added iterations opimization #1525

chore: added iterations opimization #1525

Uh oh!

Conversation

vinayakparashar commented Sep 10, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KhudaDad414 Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KhudaDad414 Sep 11, 2025 •

edited

Loading

codecov bot commented Sep 11, 2025 •

edited

Loading