Skip to content

Conversation

@deve-sh
Copy link
Collaborator

@deve-sh deve-sh commented Sep 11, 2025

  • Replaces the abortOnFailure prop to nested requests with stopOnError prop.
  • Adds tests to ensure there are no aborts due to failures in nested request's script assertions.

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.62%. Comparing base (5664702) to head (b04a667).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1526   +/-   ##
========================================
  Coverage    38.62%   38.62%           
========================================
  Files           46       46           
  Lines         3534     3534           
  Branches      1026     1026           
========================================
  Hits          1365     1365           
  Misses        2071     2071           
  Partials        98       98           
Flag Coverage Δ
unit 38.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deve-sh deve-sh requested a review from appurva21 September 11, 2025 06:01
@appurva21 appurva21 merged commit 5911e57 into develop Sep 15, 2025
11 of 14 checks passed
@appurva21 appurva21 deleted the fix/nested-requests-aborting-execution-on-encountering-error-in-scripts branch September 15, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants