fix: Incorrect name for runRequest's getProtocolMetadata accessor #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1102 +/- ##
========================================
Coverage 41.98% 41.98%
========================================
Files 14 14
Lines 817 817
Branches 214 214
========================================
Hits 343 343
Misses 434 434
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saecula
approved these changes
Jan 9, 2026
appurva21
reviewed
Jan 12, 2026
| let erroredTest = false; | ||
|
|
||
| sandboxContext.on(`execution.error.${executionId}`, (_exec, err) => { | ||
| erroredTest = true; |
appurva21
reviewed
Jan 12, 2026
| function (err) { | ||
| done(err); | ||
| sandboxContext.dispose(); | ||
| if (!erroredTest) { done(err); } |
appurva21
reviewed
Jan 12, 2026
| expect(grpcRequestResponse).to.have.property('statusCode', 0); | ||
| expect(grpcRequestResponse).to.have.property('responseTime', 100); | ||
| // Custom class property | ||
| expect(grpcRequestResponse).to.have.property('isCustomGRPCResponseClass', true); |
appurva21
approved these changes
Jan 12, 2026
appurva21
deleted the
fix/incorrect-name-for-getprotocolmetadata-accessor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.