Skip to content

Added tests support. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VShingala wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Added tests support. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6de5a0
Fixed issue where spec with resource listings were not handled
VShingala Jan 29, 2024
3b0c78d
Use simple lodash function instead of optional chaining
VShingala Jan 29, 2024
b6ee649
Added various tests and CI/CD for them as well
VShingala Jan 29, 2024
1aea1c7
Added unit tests
VShingala Jan 29, 2024
eae812c
Fixed lint issues
VShingala Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
274 changes: 261 additions & 13 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,267 @@
{
"env": {
"browser": true,
"es6": true
"parserOptions": {
"ecmaVersion": 2017
},
"extends": [
"standard"

"plugins": [
"security",
"jsdoc",
"mocha"
],
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly"
},
"parserOptions": {
"ecmaVersion": 2018,
"sourceType": "module"
"env": {
"browser": false,
"node": true,
"es6": true
},
"rules": {
// Possible Errors
"comma-dangle": ["error", "never"],
"no-cond-assign": "error",
"no-console": ["error", { "allow": ["info", "warn", "error"] }],
"no-constant-condition": "error",
"no-control-regex": "error",
"no-debugger": "error",
"no-dupe-args": "error",
"no-dupe-keys": "error",
"no-duplicate-case": "error",
"no-empty": "error",
"no-empty-character-class": "error",
"no-ex-assign": "error",
"no-extra-boolean-cast": "error",
"no-extra-parens": "off",
"no-extra-semi": "error",
"no-func-assign": "error",
"no-inner-declarations": "off",
"no-invalid-regexp": "error",
"no-irregular-whitespace": "error",
"no-negated-in-lhs": "error",
"no-obj-calls": "error",
"no-regex-spaces": "error",
"no-sparse-arrays": "error",
"no-unexpected-multiline": "error",
"no-unreachable": "error",
"no-unsafe-finally": "error",
"use-isnan": "error",
"valid-jsdoc": "warn",
"valid-typeof": "error",

// Best Practices
"accessor-pairs": "error",
//"array-callback-return": "error",
"block-scoped-var": "error",
"complexity": "off",
"consistent-return": "off",
"curly": "error",
"default-case": "error",
"dot-location": ["error", "property"],
"dot-notation": "error",
"eqeqeq": "error",
"guard-for-in": "warn",
"no-alert": "error",
"no-caller": "error",
"no-case-declarations": "error",
"no-div-regex": "error",
// "no-else-return": "error",
"no-empty-function": "error",
"no-empty-pattern": "error",
"no-eq-null": "error",
"no-eval": "error",
"no-extend-native": "error",
"no-extra-bind": "error",
"no-extra-label": "error",
"no-fallthrough": "error",
"no-floating-decimal": "error",
"no-implicit-coercion": "error",
"no-implicit-globals": "error",
"no-implied-eval": "error",
"no-invalid-this": "error",
"no-iterator": "error",
"no-labels": "error",
"no-lone-blocks": "error",
"no-loop-func": "error",
"no-magic-numbers": "off",
"no-multi-spaces": "error",
"no-multi-str": "error",
"no-native-reassign": "error",
"no-new": "error",
"no-new-func": "error",
"no-new-wrappers": "error",
"no-octal": "error",
"no-octal-escape": "error",
// "_no-param-reassign": "error",
"no-proto": "error",
"no-redeclare": "error",
"no-return-assign": "error",
"no-script-url": "error",
"no-self-assign": "error",
"no-self-compare": "error",
"no-sequences": "error",
"no-throw-literal": "error",
"no-unmodified-loop-condition": "error",
"no-unused-expressions": "off",
"no-unused-labels": "error",
"no-useless-call": "error",
"no-useless-concat": "error",
"no-useless-escape": "off",
"no-void": "error",
"no-warning-comments": "off",
"no-with": "error",
"radix": "off",
// "vars-on-top": "error",
"wrap-iife": "error",
"yoda": "error",

// Strict Mode
"strict": "off",

// Variables
"init-declarations": "off",
"no-catch-shadow": "error",
"no-delete-var": "error",
"no-label-var": "error",
"no-restricted-globals": "error",
//"no-shadow": "error",
"no-shadow-restricted-names": "error",
"no-undef": "off",
"no-undef-init": "error",
"no-undefined": "off",
"no-unused-vars": "error",
"no-use-before-define": "error",

// Stylistic Issues
"array-bracket-spacing": "error",
"block-spacing": "error",
"brace-style": [2, "stroustrup", { "allowSingleLine": true }],
"camelcase": "off",
"comma-spacing": [2, { "before": false, "after": true }],
"comma-style": ["error", "last"],
"computed-property-spacing": "error",
// "consistent-this": "warn",
"eol-last": "error",
"func-names": "off",
"func-style": "off",
"id-blacklist": "error",
"id-length": "off",
"id-match": "error",
"indent": ["error", 2, {
"VariableDeclarator": { "var": 1, "let": 1, "const": 1 },
"SwitchCase": 1
}],
"jsx-quotes": ["error", "prefer-single"],
"key-spacing": "error",
"keyword-spacing": "error",
"linebreak-style": ["error", "unix"],
"lines-around-comment": ["error", {
"beforeBlockComment": true,
"afterBlockComment": false,
"beforeLineComment": false,
"afterLineComment": false,
"allowBlockStart": true,
"allowBlockEnd": false,
"allowObjectStart": true,
"allowObjectEnd": false,
"allowArrayStart": true,
"allowArrayEnd": false
}],
"max-depth": "error",
"max-len": ["error", {
"code": 120
}],
"max-nested-callbacks": "error",
"max-params": "off",
"max-statements": "off",
"max-statements-per-line": "off",
"new-cap": "off",
"new-parens": "error",
"newline-after-var": ["off", "always"],
"newline-before-return": "off",
"newline-per-chained-call": "off",
"no-array-constructor": "error",
// "no-bitwise": "error",
// "no-continue": "error",
"no-inline-comments": "off",
"no-lonely-if": "error",
"no-mixed-spaces-and-tabs": "error",
"no-multiple-empty-lines": "error",
"no-negated-condition": "off",
"no-nested-ternary": "off",
"no-new-object": "error",
"no-plusplus": "off",
"no-restricted-syntax": "error",
"no-spaced-func": "error",
"no-ternary": "off",
"no-trailing-spaces": "error",
"no-underscore-dangle": "off",
"no-unneeded-ternary": "error",
"no-whitespace-before-property": "error",
"object-curly-spacing": ["error", "always"],
"one-var": "off",
"one-var-declaration-per-line": "error",
"operator-assignment": "error",
"operator-linebreak": ["error", "after"],
"padded-blocks": "off",
"quote-props": "off",
"quotes": "off",
"require-jsdoc": "warn",
"semi": "error",
"semi-spacing": "error",
"sort-vars": "off",
"space-before-blocks": "error",
"space-in-parens": "error",
"space-infix-ops": "error",
"space-unary-ops": "error",
"spaced-comment": ["error", "always", {
"block": {
"exceptions": ["!"]
}
}],
"wrap-regex": "error",

// ECMAScript 6
"arrow-body-style": ["error", "always"],
"arrow-parens": ["error", "always"],
"arrow-spacing": "error",
"constructor-super": "error",
"generator-star-spacing": "error",
"no-class-assign": "error",
"no-confusing-arrow": "error",
"no-const-assign": "error",
"no-dupe-class-members": "error",
"no-duplicate-imports": "error",
"no-new-symbol": "error",
"no-restricted-imports": "error",
"no-this-before-super": "error",
"no-useless-computed-key": "error",
"no-useless-constructor": "off",
"no-var": "off",
"object-shorthand": "off",
// "_prefer-arrow-callback": "error",
"prefer-const": "off",
"prefer-reflect": "off",
// "prefer-rest-params": "error",
"prefer-spread": "error",
"prefer-template": "off",
"require-yield": "error",
"sort-imports": "off",
"template-curly-spacing": "error",
"yield-star-spacing": "error",

// Mocha
"mocha/no-exclusive-tests": 2,
"mocha/no-skipped-tests": 1,
"mocha/no-pending-tests": 2,
"mocha/handle-done-callback": 2,
"mocha/no-synchronous-tests": 0,
"mocha/no-global-tests": 2,
"mocha/no-return-and-callback": 2,
"mocha/valid-test-description": 0,
"mocha/valid-suite-description": 0,
"mocha/no-sibling-hooks": 2,
"mocha/no-mocha-arrows": 2,
"mocha/no-hooks": 0,
"mocha/no-hooks-for-single-case": 1,
"mocha/no-top-level-hooks": 1,
"mocha/no-identical-title": 2
}
}
}

78 changes: 78 additions & 0 deletions .github/workflows/draft-new-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: Draft new release

on:
workflow_dispatch:
inputs:
version:
description: The version you want to release. Must be a valid semver version.
required: true
type: string

jobs:
draft-new-release:
if: startsWith(github.event.inputs.version, 'v')
name: Draft a new release
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Create release branch
run: git checkout -b release/${{ github.event.inputs.version }}

- name: Update changelog
uses: thomaseizinger/keep-a-changelog-new-release@1.1.0
with:
version: ${{ github.event.inputs.version }}

- name: Initialize mandatory git config
run: |
git config user.name "GitHub Actions"
git config user.email noreply@github.com

- name: Bump version
run: npm version ${{ github.event.inputs.version }} --git-tag-version false

- name: Commit changelog and manifest files
id: make-commit
run: |
git add CHANGELOG.md package.json package-lock.json
git commit --message "Prepare release ${{ github.event.inputs.version }}"
echo "::set-output name=commit::$(git rev-parse HEAD)"

- name: Push new branch
run: git push origin release/${{ github.event.inputs.version }}

- name: Create pull request for master
uses: thomaseizinger/create-pull-request@1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
head: release/${{ github.event.inputs.version }}
base: master
title: "Release version ${{ github.event.inputs.version }}"
reviewers: ${{ github.actor }}
body: |
Hi @${{ github.actor }}!

This PR was created in response to a manual trigger of the release workflow here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}.
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}.

- name: Create pull request for develop
uses: thomaseizinger/create-pull-request@1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
head: release/${{ github.event.inputs.version }}
base: develop
title: "Release version ${{ github.event.inputs.version }}"
reviewers: ${{ github.actor }}
body: |
Hi @${{ github.actor }}!

This PR was created in response to a manual trigger of the release workflow here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}.
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}.
Loading