Skip to content

#20 case sensitive #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#20 case sensitive #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfffb0d
case insensitive segments during folder tree building
zjrunner Oct 17, 2018
5948d7f
add tests
zjrunner Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ module.exports = {
thisPathObject,
thisPathCount,
len,
i;
i,
segmentKey;

//if a particular path has MORE than 1 props, make it a folder - always
//how to detemine subfolders?
Expand Down Expand Up @@ -417,8 +418,9 @@ module.exports = {
treeNode = tree;

for (i = 0; i < len; i++) {
if (!treeNode.children[thisPath[i]]) {
treeNode.children[thisPath[i]] = {
segmentKey = thisPath[i].toUpperCase();
if (!treeNode.children[segmentKey]) {
treeNode.children[segmentKey] = {
name: thisPath[i],
requestCount: 0,
children: {},
Expand All @@ -427,8 +429,8 @@ module.exports = {
};
}

treeNode.children[thisPath[i]].requestCount += thisPathCount;
treeNode = treeNode.children[thisPath[i]];
treeNode.children[segmentKey].requestCount += thisPathCount;
treeNode = treeNode.children[segmentKey];
}

// loop complete. Add the children here
Expand Down
22 changes: 22 additions & 0 deletions test/unit/base.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,28 @@ describe('The converter must identify invalid specs: ', function () {

//Helpers
describe('Helpers', function () {
it('getTreeFromPaths Routes should not be case sensitive', function() {
var json = {
paths:{
"/Foo/bar":{"get":{}},
"/FOO/baz":{"get":{}}
}
},
tree = Helpers.getTreeFromPaths(json);

var names = [];
for (var child in tree.children) {
if (tree.children.hasOwnProperty(child)) {
names.push(tree.children[child].name);
console.log(child);
}
}
expect(names.length).to.equal(1);
expect(names[0]).to.equal("Foo");
expect(tree.children["FOO"].children["BAR"].name).equals("bar");
expect(tree.children["FOO"].children["BAZ"].name).equals("baz");
});

it('getBasePath should return the correct basePath', function() {
var swagger = {
host: 'getpostman.com',
Expand Down