Skip to content

fix: missing data warning only when both data and error are empty #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing data warning only when both data and error are empty #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data-loaders/defineColadaLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export function defineColadaLoader<Data>(
if (this.pendingTo === to) {
// console.log(' ->', this.staged)
if (process.env.NODE_ENV === 'development') {
if (this.staged === STAGED_NO_VALUE) {
if (this.staged === STAGED_NO_VALUE && this.stagedError === null) {
console.warn(
`Loader "${key}"'s "commit()" was called but there is no staged data.`
)
Expand Down
2 changes: 1 addition & 1 deletion src/data-loaders/defineLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export function defineBasicLoader<Data>(
if (this.pendingTo === to) {
// console.log('👉 commit', this.staged)
if (process.env.NODE_ENV === 'development') {
if (this.staged === STAGED_NO_VALUE) {
if (this.staged === STAGED_NO_VALUE && this.stagedError === null) {
console.warn(
`Loader "${options.key}"'s "commit()" was called but there is no staged data.`
)
Expand Down
2 changes: 1 addition & 1 deletion src/data-loaders/defineQueryLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export function defineQueryLoader<Data, isLazy extends boolean>(
if (this.pendingTo === to && !this.error.value) {
console.log('👉 commit', this.staged)
if (process.env.NODE_ENV === 'development') {
if (this.staged === STAGED_NO_VALUE) {
if (this.staged === STAGED_NO_VALUE && this.stagedError === null) {
console.warn(
`Loader "${options.queryKey?.join(
'/'
Expand Down
2 changes: 1 addition & 1 deletion src/data-loaders/defineVueFireLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export function defineVueFireLoader<
if (this.pendingTo === to && !this.error.value) {
// console.log('👉 commit', this.staged)
if (process.env.NODE_ENV === 'development') {
if (this.staged === STAGED_NO_VALUE) {
if (this.staged === STAGED_NO_VALUE && this.stagedError === null) {
console.warn(
`Loader "${options.key}"'s "commit()" was called but there is no staged data.`
)
Expand Down