Conversation
borut-t
force-pushed
the
swiftui/animated-image
branch
from
50c5875 to
ce0fc64
Compare
tonikocjan
reviewed
Oct 3, 2025
| imageView.kf.setImage( | ||
| with: .provider(LocalFileImageDataProvider(fileURL: fileUrl)), | ||
| options: [ | ||
| .transition(.fade(animated ? 0.25 : 0)) |
Contributor
There was a problem hiding this comment.
Is this animation something that should be controlled by the user instead?
Collaborator
Author
There was a problem hiding this comment.
Good point. Let me think about it.
Collaborator
Author
There was a problem hiding this comment.
I've landed up opening all the options available to be customized.
Collaborator
Author
There was a problem hiding this comment.
Lmk how does that feel.
tonikocjan
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.