Conversation
borut-t
force-pushed
the
fix/user-defaults-kvo
branch
from
09c3470 to
efbbfe5
Compare
borut-t
force-pushed
the
fix/user-defaults-kvo
branch
from
efbbfe5 to
e8e3e23
Compare
EgzonArifi
requested changes
Nov 17, 2025
| public var wrappedValue: Value { | ||
| get { | ||
| // try to read as primitive type first (for @AppStorage compatibility) | ||
| if let primitiveValue = readPrimitive() { |
Member
There was a problem hiding this comment.
This primitive fast-path means Bool/Int/Double/Float will always return the value from UserDefaults (false/0 when the key is missing) and never fall back to defaultValue. For those types, defaultValue no longer represents “value when nothing is stored”, which is a breaking semantic change. We should probably restore a way to use defaultValue for the “missing key” case.
borut-t
force-pushed
the
fix/user-defaults-kvo
branch
from
8e8b171 to
3bfb01c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a change to handle scalar types without codable.