Open
Conversation
rjuju
requested changes
Jan 31, 2026
| * any problem. | ||
| */ | ||
| CHECK_FOR_INTERRUPTS(); | ||
| check_stack_depth(); |
Member
There was a problem hiding this comment.
the comment is probably poorly worded. The idea here wasn't to automatically raise an error in case of a too deep recursion but being able to cancel the query if this ends up recursing too much and/or infinitely.
We don't have a infinite recursion problem (at least there wasn't any such report and the this code hasn't change in years) so I would be more worried about not being able to cancel a query that has a lot of complex expressions.
Now if there were an infinite recursion then it would likely end up crashing, and crashing fast, so I'm not opposed to adding a stack depth check, but on top of the CFI, not instead of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
check_stack_depth prevents infinite loops in recursions, not CHECK_FOR_INTERRUPTS
https://github.com/postgres/postgres/blob/master/src/backend/utils/misc/stack_depth.c#L84