Pgo with maximum # of columns #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwang98
commented
Jun 26, 2025
Comment on lines
+348
to
+349
| let metrics = compiled_program.powdr_airs_metrics(); | ||
| println!("Created {} apcs out of max {}, total powdr column count {}", metrics.len(), args.apc, metrics.iter().map(|m| m.width).sum::<usize>()); |
Collaborator
Author
There was a problem hiding this comment.
powdr_airs_metrics() only counts the APC columns, not the non APC columns, but it's perplexing because in customize_exe.rs we also only cutoff by the APC columns, so it should match the input 60k max column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this for diff comparison and discussion of the features.