Runtime apc choice #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
commented
Nov 14, 2025
| } | ||
|
|
||
| pub fn add_apc_instruction_at_pc_index(&mut self, pc_index: usize, opcode: VmOpcode) { | ||
| pub fn add_apc_instruction_at_pc_index(&mut self, pc_index: usize, opcode: VmOpcode, condition: ApcCondition) { |
Author
There was a problem hiding this comment.
This is the user facing change, where the client specifies the conditions under which the apc should be chosen
Schaeff
commented
Nov 17, 2025
| )] | ||
| pub instructions_and_debug_infos: Vec<Option<(Instruction<F>, Option<DebugInfo>)>>, | ||
| pub apc_by_pc_index: HashMap<usize, (Instruction<F>, Option<DebugInfo>)>, | ||
| pub instructions_and_debug_infos: Vec<Option<(Decision<Instruction<F>>, Option<DebugInfo>)>>, |
Author
There was a problem hiding this comment.
Simplify the program to keep track of software and apc in the same vector. This reduces our diff vs upstream.
Schaeff
commented
Nov 17, 2025
| } | ||
|
|
||
| #[derive(Clone, Copy, Debug, Serialize, Deserialize)] | ||
| pub struct Decision<H> { |
Author
There was a problem hiding this comment.
This is now used across the codebase for situations where we have the choice between software and apc: handlers, pc_entries, etc.
Schaeff
commented
Nov 17, 2025
| /// Handler function pointers for tail call optimization. | ||
| #[cfg(feature = "tco")] | ||
| handlers: Vec<Handler<F, Ctx>>, | ||
| handlers: Vec<Decision<Handler<F, Ctx>>>, |
Author
There was a problem hiding this comment.
This makes is possible to pick a tco handler at runtime.
Schaeff
commented
Nov 17, 2025
| #[cfg_attr(feature = "tco", allow(dead_code))] | ||
| struct PreComputeInstruction<'a, F, Ctx> { | ||
| pub handler: ExecuteFunc<F, Ctx>, | ||
| pub handler: Decision<ExecuteFunc<F, Ctx>>, |
Author
There was a problem hiding this comment.
Same for a non-tco execution function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the prover the power to chose whether to run software or apc at runtime.
TODO: