Simplify original arenas #3438
Open
Simplify original arenas #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
commented
Nov 12, 2025
| original_arenas.ensure_initialized(apc_call_count, &self.air_by_opcode_id, &self.apc); | ||
|
|
||
| let arenas = original_arenas.arenas_mut(); | ||
| let arenas = &mut original_arenas.arenas; |
Collaborator
Author
There was a problem hiding this comment.
we use to match here
Schaeff
commented
Nov 12, 2025
|
|
||
| // Update the real number of calls to the APC | ||
| *original_arenas.number_of_calls_mut() += 1; | ||
| original_arenas.number_of_calls += 1; |
Collaborator
Author
There was a problem hiding this comment.
we use to match here
Member
|
Has conflicts |
leonardoalt
reviewed
Dec 1, 2025
Member
leonardoalt
left a comment
leonardoalt
left a comment
There was a problem hiding this comment.
lgtm as far as I understood it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During execution, we match the arenas to Initialized/Uninitialized many times under the hood. Also, we have a lot of methods on
OriginalArenaswhich delegate to Initialized/Unintialized, or panic.Simplify this by getting an
InitializedOriginalArenaat the beginning of execution.During tracegen, use the initialized status to detect if an apc was not called instead of going through
number_of_calls().I don't expect this to make much of a difference performance-wise, but it simplifies the implementation a bit.