Empirical constraints suggestions #3468
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
commented
Dec 4, 2025
| /// (most of the time), but are not guaranteed to hold in all cases. | ||
| #[derive(Serialize, Deserialize, Clone, Default, Debug)] | ||
| #[derive(Serialize, Default, Debug)] | ||
| pub struct EmpiricalConstraints { |
Collaborator
Author
There was a problem hiding this comment.
Merge DebugInfo into EmpiricalConstraints to simplify return types
Schaeff
commented
Dec 4, 2025
| } | ||
|
|
||
| #[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize, Debug, Copy, Clone)] | ||
| pub struct BlockCell { |
Collaborator
Author
There was a problem hiding this comment.
Introduce type for the equivalence class members, aka cells of a block execution
Schaeff
commented
Dec 4, 2025
Comment on lines
110
to
111
| /// - It cannot be empty | ||
| /// - It cannot hold a single element |
Collaborator
Author
There was a problem hiding this comment.
Instead of filtering out equivalence classes, keep them out by construction
Schaeff
commented
Dec 4, 2025
| Id: Eq + Hash + Copy + Ord, | ||
| { | ||
| pub fn intersect_partitions<T: Eq + Hash + Copy + Ord>( | ||
| partitions: Vec<EquivalenceClasses<T>>, |
Schaeff
commented
Dec 4, 2025
openvm/src/empirical_constraints.rs
Outdated
| } | ||
| let main = proving_context.common_main.as_ref().unwrap(); | ||
| assert_eq!(main.width, column_names.len()); | ||
| let (symbolic_machine, _) = airs.machine_by_insertion_idx.get(air_id).unwrap(); |
Collaborator
Author
There was a problem hiding this comment.
With this change to the extraction, we can access the instruction machine by air_id, so we can run the analysis on SymbolicMachine which is cleaner than on the column names.
Schaeff
commented
Dec 4, 2025
| } | ||
|
|
||
| impl<'a> ConcreteBlock<'a> { | ||
| fn equivalence_classes(&self) -> EquivalenceClasses<BlockCell> { |
Collaborator
Author
There was a problem hiding this comment.
Moved out of ConstraintDetector into this implementation
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of suggestions on top of #3461