Skip to content

Commit 03556e6

Browse files
authored
Merge pull request #545 from powerapi-ng/refactor/logging-format-string
refactor: Format logging messages the same way across the codebase
2 parents 3eb6129 + b772d51 commit 03556e6

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

.ruff.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ ignore = [
1919
"B006", # mutable-argument-default
2020
"B008", # function-call-in-default-argument
2121
"F401", # unused-import
22-
"G003", # logging-string-concat
23-
"G004", # logging-f-string
2422
"RUF005", # collection-literal-concatenation
2523
"RUF013", # implicit-optional
2624
"RUF015", # unnecessary-iterable-allocation-for-first-element

src/powerapi/handler/handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ def delegate_message_handling(self, msg: Message):
8484
handler = self.state.get_corresponding_handler(msg)
8585
handler.handle_message(msg)
8686
except UnknownMessageTypeException:
87-
self.state.actor.logger.warning("UnknowMessageTypeException: " + str(msg))
87+
self.state.actor.logger.warning("UnknownMessageTypeException: %s", msg)
8888
except HandlerException:
89-
self.state.actor.logger.warning("HandlerException")
89+
self.state.actor.logger.warning("HandlerException: %s", msg)
9090

9191

9292
class InitHandler(Handler):

src/powerapi/pusher/handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def handle(self, msg):
9191

9292
try:
9393
self.state.database.save_many(self.state.buffer)
94-
self.state.actor.logger.debug('save ' + str(len(self.state.buffer)) + ' reports in database')
94+
self.state.actor.logger.debug('Saved %d reports in the database', len(self.state.buffer))
9595
self.state.buffer = []
9696
except BadInputData as ex:
97-
self.state.actor.logger.warning(f"The report cannot be saved: {ex.msg}")
97+
self.state.actor.logger.warning('The report cannot be saved: %s', ex.msg)

0 commit comments

Comments
 (0)