Skip to content

Commit 54d4f41

Browse files
authored
Merge pull request #582 from powerapi-ng/refactor/zip-without-explicit-strict
refactor: Force error when `zip` iterables have different lengths
2 parents 0db380b + a8aac6d commit 54d4f41

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

.ruff.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,10 @@ ignore = [
1717
"E501", # line too long
1818

1919
"B006", # mutable-argument-default
20-
# "B008", # function-call-in-default-argument
2120
"F401", # unused-import
2221
"RUF013", # implicit-optional
2322

2423
"B010", # set-attr-with-constant
25-
"B905", # zip-without-explicit-strict
2624
"PT001", # pytest-fixture-incorrect-parentheses-style
2725
"PT011", # pytest-raises-too-broad
2826
"PT012", # pytest-raises-with-multiple-statements

tests/unit/dispatch_rule/test_hwpc_dispatch_rule.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,12 @@ def report_3(request):
132132
#########
133133
def validate_formula_id(formula_id_list, validation_list):
134134
"""
135-
assert if every element in formula_id_list are in validation list and
136-
vice versa
137-
138-
validation_list must be sorted
135+
assert if every element in formula_id_list are in validation list and vice versa
139136
"""
140-
assert len(formula_id_list) == len(validation_list)
141137
formula_id_list.sort()
138+
validation_list.sort()
142139

143-
for a, b in zip(formula_id_list, validation_list):
140+
for a, b in zip(formula_id_list, validation_list, strict=True):
144141
assert a == b
145142

146143

tests/unit/dispatch_rule/test_power_dispatch_rule.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,12 @@ def report1_socket0():
4343

4444
def validate_formula_id(formula_id_list, validation_list):
4545
"""
46-
assert if every element in formula_id_list are in validation list and
47-
vice versa
48-
49-
validation_list must be sorted
46+
assert if every element in formula_id_list are in validation list and vice versa
5047
"""
51-
assert len(formula_id_list) == len(validation_list)
5248
formula_id_list.sort()
49+
validation_list.sort()
5350

54-
for a, b in zip(formula_id_list, validation_list):
51+
for a, b in zip(formula_id_list, validation_list, strict=True):
5552
assert a == b
5653

5754

0 commit comments

Comments
 (0)