-
Couldn't load subscription status.
- Fork 10
Sync bucket priorities #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
30b47ee
Prioritized sync draft
benitav 1a182d5
Updates / PR feedback
benitav af6db34
Client-side polish
benitav 1a77a2b
Merge remote-tracking branch 'origin/docs' into bucket-priorities
benitav 23f770c
Typo
benitav 628f97b
Example scaffolding
benitav 8293a51
Restructure the client-side example
benitav 60c6e14
Add dart example
benitav 362d1e0
Add example apps
benitav 829d534
Add some notes for this initial release
benitav d07b32e
Merge branch 'docs' into bucket-priorities
benitav 162780c
Remove old heading
benitav 6cb53ab
Remove a note based on PR feedback
benitav a8a3e9b
Merge branch 'docs' into bucket-priorities
benitav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't have to do that now, but maybe it's helpful to also expand the "Organize Data Into Buckets" page to mention that buckets can have metadata attached to them (like the
priorityYAML key or the_priorityparameter of a parameter query).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great catch, thanks - I'll work on that next 👍