Fixed fast-base64-decode dependency issue in react-native-package. #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the prebundling work,
fast-base64-decode
was thought to be bundled in thecrypto.js
vendor file that gets injected in the rollup config. Turns out it is not the case, and sometimes this caused projects to fail startup if the dependency wasn't installed.This fix takes the small dependency and manually adds its code to the vendor file, instead of trying to figure out how to bundle a dependency that gets injected. Both the crypto and fast-base64-decode libraries are from the same author so this felt okayish.
I have tested this fix on both the monorepo and a standalone React native project.
Dev release available at: