Skip to content

Conversation

HeinrichvonStein
Copy link
Contributor

@HeinrichvonStein HeinrichvonStein commented Oct 30, 2024

This adds the functionality for a user to choose between either supabase or AWS S3 for attachment storage by changing an environment variable.

Supabase is still used for authentication.

The README contains updated instructions on how to setup an S3 bucket as well as configuring the env variables.

@benitav
Copy link
Contributor

benitav commented Oct 30, 2024

Re: questions/concerns - my feeling is that it would be cleaner (less duplication and less to maintain) if we add the S3 implementation differences/instructions separately. README probably makes sense, because I assume the instructions are heavily tied to this implementation. Alternatively in docs, https://docs.powersync.com/usage/use-case-examples/attachments-files, but that might be difficult to remember to update if we update the example implementation.

@HeinrichvonStein HeinrichvonStein marked this pull request as draft October 31, 2024 07:19
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 877206f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HeinrichvonStein HeinrichvonStein marked this pull request as ready for review October 31, 2024 08:50
@HeinrichvonStein HeinrichvonStein changed the title [Demo] React Native AWS S3 Todo App Add attachment storage options for React Native Todo Demo App Oct 31, 2024
@DominicGBauer DominicGBauer deleted the rn-aws-s3-todolist branch December 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants