feat: refresh watched queries on schema changes #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved optionalSync test schema to separate file.
…nChangeWithAsyncGenerator. Ensuring abortControllers are called in watchSchemaChange tests.
…uth flow issue in optional sync demo.
🦋 Changeset detectedLatest commit: 506aaee The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chriztiaan
requested review from
mugikhan
and removed request for
DominicGBauer
Chriztiaan
commented
Nov 5, 2024
stevensJourney
previously approved these changes
Nov 6, 2024
# Conflicts: # packages/react-native/package.json # pnpm-lock.yaml
stevensJourney
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces fixes for problems encountered when schema changes are made against tables being depended on in watched queries (
watch()and hooks/composable).The problem affected web and react-native in different ways.
common/AbstractPowerSyncDatabase's watch functions,react,tanstack-react-query, andvue.A similar API addition for
refreshSchema()was made to the Dartsqlite-asyncproject here.This PR also includes a small fix to the optional sync's demo (this demo was used for testing the original bug).
Testing
Originally, after the schema was changed - inserts wouldn't reflect in the UI for watch watched queries. Inserts do reflect now as expected.