Skip to content

Conversation

ImSingee
Copy link
Contributor

The latest drizzle-orm version is 0.36.1, but @powersync/drizzle-driver now requires a [email protected] dependency (This indicates >=0.35.2 & < 0.36).

This PR:

  1. use peer dependency instead of dependency
  2. allow a more wide range version of drizzle-orm (>=0.35.2 & <1)

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: a1b9ac1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Chriztiaan Chriztiaan self-requested a review November 14, 2024 10:46
@Chriztiaan
Copy link
Contributor

Chriztiaan commented Nov 14, 2024

The caret allows changes that do not modify the left-most non-zero element. So this change would only support ^0.35.2 := >=0.35.2 <0.36.0-0.

@ImSingee
Copy link
Contributor Author

Oh yes.

Simply >=0.35.2 <1 works. But I’m off computer, I will update it later (or I believe you can just help me update this)

@Chriztiaan
Copy link
Contributor

I am currently testing an alternative that we use for some of our other packages: #404

@ImSingee
Copy link
Contributor Author

Hmm, I don’t think * is a good idea in any ways. Only god knows what will happen in the future. If we don’t want limit the lowest version, at least we should use <1

@Chriztiaan
Copy link
Contributor

Would be willing to test that it resolves the dependency issue on your side @ImSingee ?
I made a dev release at: @powersync/[email protected]

@ImSingee
Copy link
Contributor Author

@Chriztiaan Yes, it works well with the latest drizzle-orm version

@Chriztiaan
Copy link
Contributor

Resolved in #404

@ImSingee ImSingee closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants