Skip to content

Conversation

HeinrichvonStein
Copy link
Contributor

@HeinrichvonStein HeinrichvonStein commented Dec 18, 2024

This PR addresses #431 (comment).

Add validation to the Schema constructor.

  • We need to validate that the tables have a name here because a user could pass in an array Tables that don't have a name because they are using the V2 syntax. Therefore, 'convertToClassicTables' won't be called on the tables resulting in a runtime error.

Additional Tests:

  • Added a new Schema test which checks that an error is thrown when a Schema is created incorrectly.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: ebd981d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HeinrichvonStein HeinrichvonStein marked this pull request as draft December 18, 2024 08:48
@HeinrichvonStein
Copy link
Contributor Author

Converting to a draft for now due to validation oversite

@HeinrichvonStein HeinrichvonStein marked this pull request as ready for review December 18, 2024 09:45
DominicGBauer
DominicGBauer previously approved these changes Dec 18, 2024
stevensJourney
stevensJourney previously approved these changes Dec 18, 2024
@HeinrichvonStein HeinrichvonStein merged commit 9fbe5b2 into main Dec 18, 2024
6 checks passed
@HeinrichvonStein HeinrichvonStein deleted the fix/schema-validation branch December 18, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants