-
Notifications
You must be signed in to change notification settings - Fork 58
Added executeRaw() #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Added executeRaw() #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbe68fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ad of depending on a native implementation.
Chriztiaan
commented
Mar 19, 2025
packages/react-native/src/db/adapters/react-native-quick-sqlite/RNQSDBAdapter.ts
Outdated
Show resolved
Hide resolved
packages/react-native/src/db/adapters/react-native-quick-sqlite/RNQSDBAdapter.ts
Outdated
Show resolved
Hide resolved
…ontain the columns as keys anymore - this was a no-op.
stevensJourney
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment duplicate column names in a query result are overwritten with only the last column being the one returned. This causes issues with join queries (a simple case is where multiple
id
columns are returned) and is most prominent when doing joins with one of the ORM drivers (Kysely/Drizzle). This issue is covered by the newly added tests.This PR introduces
executeRaw
which processes the sqlite results differently and allows the Drizzle ORM driver to correctly map the resulting columns.An existing approach for Drizzle-orm packages can be seen here:
https://github.com/drizzle-team/drizzle-orm/blob/main/drizzle-orm/src/op-sqlite/session.ts#L165
https://github.com/drizzle-team/drizzle-orm/blob/main/drizzle-orm/src/better-sqlite3/session.ts#L156
Sqlite Adapters Affected
Opted to not implement
executeRaw
in the RNQS package for now, the adapter falls back toexecute
- resulting in the initial behaviour. Users who need this functionality are encouraged to migrate to OPSQLite at the moment.Using OPSQLite
executeRaw
function, which is also used for their Drizzle integration.Updated
WASQLiteConnection
to expose a raw execute function, simply handling the result differently.Using BetterSqlite3's
raw()
- which is also used for the BSQLite3 Drizzle integration.Original Workaround
For Drizzle users using joins the following example shows how to side-step the problem in the interim:
Reported in #473