-
Notifications
You must be signed in to change notification settings - Fork 58
Support bucket priorities #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e04c040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. I didn't review the specifics of the new sync protocol.
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the changes here :)
Support bucket priorities by recognizing partial checkpoint complete messages and forwarding their status to the core extension: When receiving a
checkpoint
message, we remember the priorities of involved buckets. For apartial_checkpoint_complete
message, we then validate and sync only the buckets with matching priorities.We also expose the sync state within each priority through the
SyncStatus
objects and expandwaitForFirstSync
to optionally wait only for a first sync within a priority.