Conversation
🦋 Changeset detectedLatest commit: e04c040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
Left some minor comments. I didn't review the specifics of the new sync protocol.
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Outdated
Show resolved
Hide resolved
simolus3
commented
Feb 25, 2025
stevensJourney
approved these changes
Feb 25, 2025
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
I'm happy with the changes here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support bucket priorities by recognizing partial checkpoint complete messages and forwarding their status to the core extension: When receiving a
checkpointmessage, we remember the priorities of involved buckets. For apartial_checkpoint_completemessage, we then validate and sync only the buckets with matching priorities.We also expose the sync state within each priority through the
SyncStatusobjects and expandwaitForFirstSyncto optionally wait only for a first sync within a priority.