-
Notifications
You must be signed in to change notification settings - Fork 58
Add NodeJS implementation #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 87179ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some very minor comments. Overall this looks great to me.
I ran the web tests locally, they still pass. |
This adds a NodeJS implementation based on the amazing work done by @spinda in this fork. I've followed up on that work by:
install
script, and loading it when databases are opened (that seemed like the simplest option for now, bundling the shared libraries with the package would probably be a better approach).