Skip to content

Add attachmentDirectoryName to AbstractAttachmentQueue get table and add blurb to Readme #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add attachmentDirectoryName to AbstractAttachmentQueue get table and add blurb to Readme #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9d523c
Add attachmentDirectoryName to AbstractAttachmentQueue get table
jessemcintire Mar 8, 2025
f8659bd
Merge branch 'main' into feat/set-custom-attachments-table-name
jessemcintire Mar 12, 2025
c060ea3
Merge branch 'main' into feat/set-custom-attachments-table-name
jessemcintire Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/attachments/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ In addition to `Table` options, the `AttachmentTable` can optionally be configur
| `name` | The name of the table | `attachments` |
| `additionalColumns` | An array of addition `Column` objects added to the default columns in the table | See below for default columns |

If you decided to name the attachments table something other than `attachments` using the `AttachmentTable.name` property then you must also set `attachmentDirectoryName` to the same name when creating an instance of the `AttachmentQueue`

The default columns in `AttachmentTable`:

| Column Name | Type | Description |
Expand Down
2 changes: 1 addition & 1 deletion packages/attachments/src/AbstractAttachmentQueue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export abstract class AbstractAttachmentQueue<T extends AttachmentQueueOptions =
}

get table() {
return ATTACHMENT_TABLE;
return this.options.attachmentDirectoryName || ATTACHMENT_TABLE;
}

async init() {
Expand Down