Fix missing filter when setting last_op
#586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we receive a (partial) checkpoint complete and have validated checksums, we set
last_op
to thelast_op_id
of the checkpoint for involved buckets.Due to an ignored filter in
syncLocalDatabase
, we were raisinglast_op
even for buckets with lower priorities when receiving a partial completion for a higher priority. Having a wrong value inlast_op_id
is a problem when the sync stream gets reset without completing a full checkpoint afterwards, because we use that value to create the next request when reconnecting.