Dont block on crud uploads #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d52f71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
commented
Jul 11, 2025
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Show resolved
Hide resolved
rkistner
previously approved these changes
Jul 11, 2025
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Outdated
Show resolved
Hide resolved
rkistner
approved these changes
Jul 11, 2025
whygee-dev
pushed a commit
to whygee-dev/powersync-js
that referenced
this pull request
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the Rust approach of listening to CRUD upload completions to the JS client as well.
Instead of polling on a promise that resolves on a CRUD upload, we register a listener on completed uploads as a callback. This callback then schedules another round of the main loop handling sync lines, triggering another attempt to apply the checkpoint. This mirrors the "merged streams" approach we have in Dart (and also in the Rust client).
To support this, I had to remove the non-raw methods from
AbstractRemote- we need custom line mapping to inject the parsed upload complete notifications.