Skip to content

Fix crash in React Native: add optional chaining to stream?.close() #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix crash in React Native: add optional chaining to stream?.close() #668

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979143b
Update AbstractRemote.ts
felixgourdeau Jul 19, 2025
286e0c0
Update AbstractRemote.ts
felixgourdeau Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common/src/client/sync/stream/AbstractRemote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ export abstract class AbstractRemote {
clearTimeout(keepAliveTimeout);
keepAliveTimeout = setTimeout(() => {
this.logger.error(`No data received on WebSocket in ${SOCKET_TIMEOUT_MS}ms, closing connection.`);
stream.close();
stream?.close();
}, SOCKET_TIMEOUT_MS);
};
resetTimeout();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the issue correctly, I think the stream variable has not been assigned by the time the first timeout happens - perhaps due to the initial connection taking longer than the timeout.

I think we might be able to avoid this by removing the resetTimeout call here which starts the timeout process before connector.connect() has been called.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense. I've updated the PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here! After digging deeper into this issue, I realized that we should handle a timeout during the initial connect call better. I've implemented that timeout functionality here #671
If that PR gets merged we can close this one. Thanks again for for bringing this issue to our attention and for all your efforts.

Expand Down