Fix: Rust Client Disconnect Race #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When disconnecting and connecting frequently, it is currently possible for the Rust sync clients to get locked in a frozen state if the
StreamingSyncClient
is disconnected/aborted before it has connected.This can happen if:
StreamingSyncImplementation
'sAbortController
is marked as aborted, but we nest theAbortController
here.AbortSignal
has been aborted before making the request (and we throw), but due to the wrapped controller used in the Rust implementation we don't detect that the wrapped controller has been aborted. The wrapped controller will also never be aborted since the upstream controller won't emit theaborted
event again (since it was aborted before)ConnectionManager
'sdisconnectingPromise
never resolves, which causes a shared sync implementation to be frozen.This checks the upstream AbortSignal before wrapping it. The abort is propagated by throwing a
AbortOperation
.This could also have happened with the HTTP connection method. A check has been added there also.